fix(deparser): emit alias-qualifier unquoted, always quote identifiers#29
Merged
Conversation
Qualified column references (`f.col`) used to go through the dialect's `quoteIdentifier(qual, name)`, which wrapped both parts under the dialect's quoting policy. The FROM clause emitted aliases unquoted (`AS f`), so `"f"."col"` no longer matched the case-folded alias `F` and H2 rejected the SQL. The qualifier is now appended verbatim and only the column name is wrapped in the dialect's quote character. FROM-clause catalog/schema/table names are also always quoted. The SqlGuard already resolves identifiers against the database catalog before deparsing, so the AST carries canonical-case names that match the engine's case-sensitive lookup. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
stbischof
changed the title
table names Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qualified column references (
f.col) used to go through the dialect'squoteIdentifier(qual, name), which wrapped both parts under thedialect's quoting policy. The FROM clause emitted aliases unquoted (
AS f), so"f"."col"no longer matched the case-folded aliasFand H2rejected the SQL.
The qualifier is now appended verbatim and only the column name is
wrapped in the dialect's quote character. FROM-clause
catalog/schema/table names are also always quoted. The SqlGuard already
resolves identifiers against the database catalog before deparsing, so
the AST carries canonical-case names that match the engine's
case-sensitive lookup.